Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter to set the build image #3

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

kjsanger
Copy link
Member

@kjsanger kjsanger commented Aug 19, 2024

The previous method to work around that Docker container GitHub Actions can't accept parameters doesn't actually work. This is a different workaround which, while inefficient, at least gives the desired result.

Please squash the commits.

Resolves #1

@kjsanger kjsanger added the bug Something isn't working label Aug 19, 2024
@mksanger
Copy link

Looks good to me. I don't have write access on this repo, so can't merge it

@jmtcsngr jmtcsngr merged commit c3b5907 into wtsi-npg:devel Aug 20, 2024
5 checks passed
@kjsanger kjsanger deleted the fix/composite branch August 20, 2024 11:59
@kjsanger
Copy link
Member Author

I don't have write access on this repo, so can't merge it

I'll fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a parameter to set the base iRODS dev image
3 participants